Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the logic for static flight response generation #36984

Merged
merged 5 commits into from
May 18, 2022
Merged

Simplify the logic for static flight response generation #36984

merged 5 commits into from
May 18, 2022

Conversation

shuding
Copy link
Member

@shuding shuding commented May 17, 2022

We used to generate the flight page data using a stream which is totally overhead because in that scenario we don't need to stream. This PR simplifies it to just use a string variable.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels May 17, 2022
@shuding shuding marked this pull request as ready for review May 17, 2022 14:35
@ijjk
Copy link
Member

ijjk commented May 17, 2022 •
edited
Loading

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary shuding/next.js shu/a796 Change
buildDuration 16.7s 16.9s ⚠️ +217ms
buildDurationCached 6.6s 6.3s -311ms
nodeModulesSize 478 MB 478 MB -2.32 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/a796 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.981 4.043 ⚠️ +0.06
/ avg req/sec 627.91 618.42 ⚠️ -9.49
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.493 1.509 ⚠️ +0.02
/error-in-render avg req/sec 1674.12 1657.13 ⚠️ -16.99
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/a796 Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 28.8 kB 28.8 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 72.4 kB 72.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/a796 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary shuding/next.js shu/a796 Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 308 B 308 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.71 kB 2.71 kB ✓
head-HASH.js gzip 359 B 359 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.72 kB 5.72 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.65 kB 2.65 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 391 B 391 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16 kB 16 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js shu/a796 Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/a796 Change
index.html gzip 531 B 531 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary shuding/next.js shu/a796 Change
buildDuration 19s 18.5s -484ms
buildDurationCached 6.5s 6.6s ⚠️ +80ms
nodeModulesSize 478 MB 478 MB -2.32 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/a796 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.161 4.091 -0.07
/ avg req/sec 600.86 611.06 +10.2
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.457 1.471 ⚠️ +0.01
/error-in-render avg req/sec 1715.71 1700.02 ⚠️ -15.69
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/a796 Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.7 kB 42.7 kB ✓
main-HASH.js gzip 29.2 kB 29.2 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 73.5 kB 73.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/a796 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary shuding/next.js shu/a796 Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 311 B 311 B ✓
css-HASH.js gzip 324 B 324 B ✓
dynamic-HASH.js gzip 2.89 kB 2.89 kB ✓
head-HASH.js gzip 357 B 357 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.81 kB 5.81 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.78 kB 2.78 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 392 B 392 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16.3 kB 16.3 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js shu/a796 Change
_buildManifest.js gzip 457 B 457 B ✓
Overall change 457 B 457 B ✓
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/a796 Change
index.html gzip 531 B 531 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 7037954

@shuding shuding requested a review from huozhi May 18, 2022 10:11
@shuding shuding merged commit b2045c7 into vercel:canary May 18, 2022
@shuding shuding deleted the shu/a796 branch May 18, 2022 11:18
SukkaW pushed a commit to SukkaW/next.js that referenced this pull request May 18, 2022
@shuding @SukkaW
Simplify the logic for static flight response generation (vercel#36984)
b553818 
* code refactor

* simplify static data

* htmlEscapeJsonString in view-render
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@padmaia padmaia Awaiting requested review from padmaia

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shuding @ijjk @huozhi